Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 visibility追加、v1API削除 #777

Merged
merged 9 commits into from
Dec 3, 2023
Merged

Conversation

ikura-hamu
Copy link
Member

  • ゲームの公開範囲の概念を追加
  • それに伴い、変更箇所が大きくなりすぎていたので、v1のAPIを削除

@ikura-hamu ikura-hamu mentioned this pull request Dec 3, 2023
3 tasks
Copy link

codecov bot commented Dec 3, 2023

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (68ba8ba) 61.17% compared to head (10680b5) 51.74%.
Report is 32 commits behind head on develop.

Files Patch % Lines
src/handler/v2/checker.go 0.00% 7 Missing ⚠️
src/handler/v2/game.go 45.45% 6 Missing ⚠️
src/domain/game.go 0.00% 5 Missing ⚠️
src/repository/gorm2/db.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #777      +/-   ##
===========================================
- Coverage    61.17%   51.74%   -9.44%     
===========================================
  Files          125       91      -34     
  Lines        11656     8028    -3628     
===========================================
- Hits          7131     4154    -2977     
+ Misses        4142     3616     -526     
+ Partials       383      258     -125     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ikura-hamu ikura-hamu merged commit b3d941e into develop Dec 3, 2023
6 of 8 checks passed
@ikura-hamu ikura-hamu deleted the feat/visibility_api branch December 3, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant