Better patch for #13, #14, #15

[Orio91]

This one should be cleaner than #22 :)

[crayfishuk]

How can I copy this into my trac server to test -- am keen to use the code-commenting but need to have #14 fixed before we can use it in our team (multiple repositories!)

Thanks!

-Craig

(We're an SVN shop here - not had much git exposure, so be gentle :) )

[nb]

@Orio91 thanks for the updated pull request, I will look into the code.

@crayfishuk you can download @Orio91's version of the plugin from here: https://github.com/Orio91/trac-code-comments-plugin/zipball/master_clean

[crayfishuk]

Can't assist with patches. However - upgrade from code_comments db v1 - v3 is broken. Fails with 'No such column: repository'. Suspect that the upgrade from 1->2 needs to not require 'repository' column in schema.

Fixed by:-

• editing db.py to remove column 'repository' from schema (line 20)
• Set db_version = 2
• Run trac-admin upgrade
• edit db.py to include 'repository'
• Set db_version =3
• Run trac-admin upgrade again.

All appears to be ok - will report if I have any problems during use. Thanks for quick response on this!!! Fab :)

[fzhan]

This is not for mysql, could you please provide a solution for mysql?

Thanks

[nb]

Thanks, @rjollos, you’re right that the plugin is not maintained and thanks for forking the plugin. Let us know if there is a better way to send users your way.

[rjollos]

Let us know if there is a better way to send users your way.

@nb Would you be willing to transfer the repository to the trac-hacks GitHub org? That way we would get all the open issues and the URL would redirect to the new location.

If yes, just let me know and I'll setup so the repository can be transferred.

[rjollos]

@nb Would you be willing to transfer the repository to the trac-hacks GitHub org? That way we would get all the open issues and the URL would redirect to the new location.

I recall now that we discussed in #53.

[nb]

@rjollos, sure, transferring sounds good – let’s do it, let me know when you’re done with the setup and I will transfer it.

[rjollos]

Thanks! You should receive an invite to join the trac-hacks organization. Accepting will allow you to execute these steps and transfer the repository.

[nb]

@rjollos, unfortunately the transfer cannot be initiated, because of the https://github.com/trac-hacks/trac-code-comments-plugin-2 fork. From the docs:

The target account must not have a repository with the same name, or a fork in the same network.

Maybe you can delete the repo on GitHub, but save the comments locally and replay them on the new remote later when we transfer it?

[rjollos]

Maybe you can delete the repo on GitHub, but save the comments locally and replay them on the new remote later when we transfer it?

Done. Thanks for sorting that out.

[nb]

Moving repository to trac-hacks/trac-code-comments-plugin. This may take a few minutes.

Thanks for the patience and for saving the project, @rjollos 🎉💯