fix/ndarray: remove reversed axes check #1058
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Checklist
run-checks all
script has been executed.Related Issues/PRs
fix #1053
Changes
Remove reversed axes layout check to allow column major tensor to be reshaped into row major.
Testing
Ran
cargo test
underburn-ndarray
andrun-checks all
NOTE: Although the shape() bug can be fixed by this, there is still some weird logic in
ndarry::concatenate(...)
function to compute new strides for empty tensors where they prefer to producing column major layout. Maybe we should callreshape(...)
inNdArrayOps::cat(...)
too and add some tests against thecat
result.