Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wgpu fusion auto-vectorized operations #1123

Merged
merged 9 commits into from
Jan 8, 2024
Merged

Conversation

nathanielsimard
Copy link
Member

Fix #1111

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 143 lines in your changes are missing coverage. Please review.

Comparison is base (3c056a4) 85.59% compared to head (3409b39) 85.51%.
Report is 2 commits behind head on main.

❗ Current head 3409b39 differs from pull request most recent head e2fb3fb. Consider uploading reports for the commit e2fb3fb to get more accurate results

Files Patch % Lines
burn-wgpu/src/codegen/operator.rs 79.48% 64 Missing ⚠️
burn-wgpu/src/codegen/function.rs 65.95% 32 Missing ⚠️
burn-wgpu/src/fusion/elemwise/optimization.rs 71.87% 18 Missing ⚠️
burn-wgpu/src/codegen/variable.rs 75.00% 12 Missing ⚠️
burn-wgpu/src/fusion/elemwise/kernel.rs 91.86% 7 Missing ⚠️
burn-wgpu/src/codegen/kernel.rs 93.33% 3 Missing ⚠️
burn-wgpu/src/fusion/kernel.rs 96.84% 3 Missing ⚠️
burn-wgpu/src/codegen/shader.rs 88.23% 2 Missing ⚠️
burn-wgpu/src/fusion/elemwise/builder.rs 88.23% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1123      +/-   ##
==========================================
- Coverage   85.59%   85.51%   -0.09%     
==========================================
  Files         512      513       +1     
  Lines       55968    56593     +625     
==========================================
+ Hits        47907    48394     +487     
- Misses       8061     8199     +138     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@louisfd louisfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good to me, vec4 all the way!!

@@ -158,6 +158,7 @@ where
}

let source = kernel.source().complete();
// println!("{source}");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining print comment

@nathanielsimard nathanielsimard merged commit de5f932 into main Jan 8, 2024
0 of 12 checks passed
@nathanielsimard nathanielsimard deleted the feat/wgpu-fusion-vec4 branch January 8, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support auto-vectorization of fused compute shaders
2 participants