Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix small typos and dead links in README and burn-book #1127

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Fix small typos and dead links in README and burn-book #1127

merged 1 commit into from
Jan 10, 2024

Conversation

laggui
Copy link
Member

@laggui laggui commented Jan 9, 2024

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Changes

  • Fixed some minor typos in README and burn book
  • Fixed dead links to sections in book (../building-blocks/README.md rendered to building-blocks/README.html which is invalid)
  • Changed "concentrate" to "focus" (subjective edit, but feels more natural to say)

syl20bnr
syl20bnr approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@syl20bnr syl20bnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you for fixes !

@louisfd louisfd merged commit 15c2f3b into main Jan 10, 2024
@nathanielsimard nathanielsimard deleted the docs/fix-typos branch January 10, 2024 13:57
@laggui laggui restored the docs/fix-typos branch January 16, 2024 13:02
@laggui laggui deleted the docs/fix-typos branch January 16, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louisfd louisfd louisfd approved these changes

@syl20bnr syl20bnr syl20bnr approved these changes

@nathanielsimard nathanielsimard Awaiting requested review from nathanielsimard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laggui @syl20bnr @louisfd