Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[xtask] Update xtask publish task #1189

Merged
merged 2 commits into from
Jan 30, 2024
Merged

[xtask] Update xtask publish task #1189

merged 2 commits into from
Jan 30, 2024

Conversation

Luni-4
Copy link
Collaborator

@Luni-4 Luni-4 commented Jan 30, 2024

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Changes

This PR updates xtask publish task and fixes some format inconsistencies and typos

@Luni-4 Luni-4 requested a review from syl20bnr January 30, 2024 09:29
@Luni-4
Copy link
Collaborator Author

Luni-4 commented Jan 30, 2024

@syl20bnr

I think we should also refactor the publish.rs file using the new structure, there is code duplication in there

syl20bnr
syl20bnr approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@syl20bnr syl20bnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Yes you are right, the file can be refactored to use the functions in utils.

@nathanielsimard nathanielsimard merged commit b8a1c86 into tracel-ai:main Jan 30, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syl20bnr syl20bnr syl20bnr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Luni-4 @syl20bnr @nathanielsimard