Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix training dashboard metrics switch #1228

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Conversation

nathanielsimard
Copy link
Member

On Linux & Mac OS switching metrics were not working.

Copy link
Member

@louisfd louisfd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Mac OS, it works

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b8915e9) 84.41% compared to head (a0488c5) 84.41%.
Report is 1 commits behind head on main.

Files Patch % Lines
burn-train/src/renderer/tui/metric_numeric.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1228   +/-   ##
=======================================
  Coverage   84.41%   84.41%           
=======================================
  Files         549      549           
  Lines       61952    61952           
=======================================
  Hits        52295    52295           
  Misses       9657     9657           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syl20bnr syl20bnr merged commit f396094 into main Feb 1, 2024
14 of 15 checks passed
@syl20bnr syl20bnr deleted the fix/train-dashboard-metrics branch February 1, 2024 18:56
syl20bnr pushed a commit that referenced this pull request Feb 1, 2024
syl20bnr pushed a commit that referenced this pull request Feb 1, 2024
syl20bnr pushed a commit that referenced this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants