Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/autodiff/checkpoint ops #1358

Merged
merged 64 commits into from
Feb 26, 2024
Merged

Conversation

louisfd
Copy link
Member

@louisfd louisfd commented Feb 23, 2024

Finally, a real PR for autodiff checkpointing.
There is now a way to do no checkpointing by considering everything to be compute bound. It is set by default, so this should be able to merge without impacting anything.

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 82.68377% with 351 lines in your changes are missing coverage. Please review.

Project coverage is 85.60%. Comparing base (cbf7550) to head (79eab9d).
Report is 1 commits behind head on main.

Files Patch % Lines
crates/burn-autodiff/src/ops/module.rs 69.91% 108 Missing ⚠️
crates/burn-autodiff/src/ops/tensor.rs 88.02% 100 Missing ⚠️
crates/burn-autodiff/src/checkpoint/builder.rs 62.94% 73 Missing ⚠️
...ates/burn-autodiff/src/checkpoint/retro_forward.rs 45.94% 20 Missing ⚠️
crates/burn-autodiff/src/checkpoint/state.rs 77.21% 18 Missing ⚠️
crates/burn-autodiff/src/checkpoint/strategy.rs 42.85% 16 Missing ⚠️
crates/burn-autodiff/src/checkpoint/base.rs 62.16% 14 Missing ⚠️
crates/burn-autodiff/src/ops/activation.rs 98.36% 1 Missing ⚠️
crates/burn-autodiff/src/tensor.rs 96.55% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1358      +/-   ##
==========================================
- Coverage   85.69%   85.60%   -0.09%     
==========================================
  Files         586      592       +6     
  Lines       65339    66836    +1497     
==========================================
+ Hits        55993    57216    +1223     
- Misses       9346     9620     +274     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

crates/burn-autodiff/Cargo.toml Outdated Show resolved Hide resolved
crates/burn-autodiff/src/checkpoint/base.rs Outdated Show resolved Hide resolved
crates/burn-autodiff/src/checkpoint/base.rs Show resolved Hide resolved
crates/burn-autodiff/src/ops/base.rs Outdated Show resolved Hide resolved
crates/burn-autodiff/src/ops/base.rs Outdated Show resolved Hide resolved
crates/burn-autodiff/src/ops/base.rs Outdated Show resolved Hide resolved
crates/burn-autodiff/src/ops/base.rs Outdated Show resolved Hide resolved
crates/burn-autodiff/src/ops/base.rs Outdated Show resolved Hide resolved
@nathanielsimard nathanielsimard merged commit 576bb44 into main Feb 26, 2024
15 checks passed
@nathanielsimard nathanielsimard deleted the feat/autodiff/checkpoint_ops branch February 26, 2024 22:19
@femshima femshima mentioned this pull request Jun 17, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants