-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add linear learning rate scheduler #1443
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1443 +/- ##
==========================================
+ Coverage 85.76% 85.82% +0.06%
==========================================
Files 640 644 +4
Lines 70632 71563 +931
==========================================
+ Hits 60577 61420 +843
- Misses 10055 10143 +88 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! 🙏
Overall, LGTM. Just a minor comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I missed some comments in the last review since it is retroactive to the change of step_size
to f64
. The changes were kind of implicit but that's my fault 😅
See my comments below, and then LGTM 🚀
Alright, it should be resolved now. Thanks! |
Checklist
run-checks all
script has been executed.Related Issues/PRs
#1198
Changes
This PR adds a linear learning rate scheduler to Burn, which didn't exist previously. This makes progress towards the issue linked above.
Testing
I wrote tests to confirm that invalid config parameters are rejected and that the learning rate changes over iterations as expected. I successfully ran
run-checks.sh all
. I also checked the appearance of the new documentation viacargo doc --open
.