Add flip tensor operator
#1468
Merged
Add flip tensor operator
#1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1468 +/- ##
==========================================
+ Coverage 85.70% 85.76% +0.05%
==========================================
Files 645 648 +3
Lines 71953 72497 +544
==========================================
+ Hits 61669 62178 +509
- Misses 10284 10319 +35 ☔ View full report in Codecov by Sentry. |
nathanielsimard
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
LGTM, seems pretty well done. Requesting @louisfd to double check before merging, but great job! 🎉
|
Reviewed it myself and merged it so we can unblock new tensor op PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Checklist
run-checks allscript has been executed.Related Issues/PRs
Changes
Added
flipoperation for tensors like the pytorch one. It has also been implemented for all backends.The implementation for the Candle backend may be slow, but it can be replaced with more suitable methods, such as flip or step indexing, once these are implemented on Candle.
Testing
Added unit tests.