-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backend-comparison] Add Operating System information #1531
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1531 +/- ##
==========================================
- Coverage 85.99% 85.97% -0.02%
==========================================
Files 668 669 +1
Lines 76372 76421 +49
==========================================
+ Hits 65673 65705 +32
- Misses 10699 10716 +17 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I simplified the serialized struct. New examples:
"os": {
"name": "Ubuntu 20.4.0 (focal) [64-bit]",
"wsl": true
}
"os": {
"name": "Windows 10.0.22621 (Windows 11 Core) [64-bit]",
"wsl": false
}
"os": {
"name": "Mac OS 14.4.0 [64-bit]",
"wsl": false
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well that was easy! LGTM 🚀
I will merge this PR at the end of all the modifications. I'll deploy the server to production and reset the database, |
Checklist
run-checks all
script has been executed.Related Issues/PRs
#1519
Changes
Serialize the operating system information and detect the windows linux subsystem.
Examples: