Add reduce sum onnx ops to burn imports #1723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1723 +/- ##
==========================================
+ Coverage 86.47% 86.49% +0.01%
==========================================
Files 698 698
Lines 82874 83041 +167
==========================================
+ Hits 71667 71827 +160
- Misses 11207 11214 +7 ☔ View full report in Codecov by Sentry. |
antimora
requested changes
May 5, 2024
| @@ -798,6 +798,61 @@ pub fn reduce_mean_config(node: &Node) -> Option<usize> { | |||
| } | |||
| } | |||
|
|
|||
| pub fn reduce_sum_config(node: &Node) -> Option<usize> { | |||
| dbg!(&node); | |||
There was a problem hiding this comment.
Probably by accident this is checked in: dbg!(&node)l
There was a problem hiding this comment.
Oops, yeah! Sorry, should be gone now
AntBlo
force-pushed
the
add-reduce-sum-onnx-ops-to-burn-imports
branch
from
1be010a
to
4da8d3d
Compare
antimora
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Checklist
run-checks allscript has been executed.Related Issues/PRs
#1714
Changes
Implements the ReduceSum ONNX Op.
Testing
Wrote tests for 11 and 13 ReduceSum opset