Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Less + LessOrEqual onnx import #1800

Merged
merged 1 commit into from
May 23, 2024

Conversation

JachymPutta
Copy link
Contributor

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

Provide links to relevant issues and dependent PRs.

Changes

Added the less and lessOrEqual operators to the onnx import

Testing

Tested locally with
cargo test less

Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 95.45455% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 86.45%. Comparing base (e39b4d2) to head (6871c8c).

Files Patch % Lines
crates/burn-import/src/burn/node/binary.rs 92.30% 2 Missing ⚠️
crates/burn-import/src/onnx/dim_inference.rs 90.90% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1800   +/-   ##
=======================================
  Coverage   86.44%   86.45%           
=======================================
  Files         746      746           
  Lines       86121    86209   +88     
=======================================
+ Hits        74448    74532   +84     
- Misses      11673    11677    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're on a roll! 😉

LGTM! Thanks for the contribution.

@laggui laggui merged commit 1f31e20 into tracel-ai:main May 23, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants