Feat/gather import #1843
Merged
Feat/gather import #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1843 +/- ##
==========================================
+ Coverage 86.24% 86.26% +0.01%
==========================================
Files 767 768 +1
Lines 88575 88701 +126
==========================================
+ Hits 76394 76516 +122
- Misses 12181 12185 +4 ☔ View full report in Codecov by Sentry. |
antimora
approved these changes
Jun 1, 2024
laggui
approved these changes
Jun 3, 2024
LilDojd
pushed a commit
to LilDojd/burn
that referenced
this pull request
Jun 5, 2024
* Move and redirect GatherElements to new folders/nodes * Create PyTorch script for gather * Add onnx file for gather * Add a gather test to onnx_tests * Update gather.rs to use select * Rename codegen test * Update gather and gather_elements conversion functions * Validate rank of input node and update output * Add check for Gather
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Checklist
run-checks allscript has been executed.Related Issues/PRs
#1714
Changes
Gather and GatherElements were separated into their own folders on the ONNX side. Confusingly, ONNX's
GatherElementsis equivalent to PyTorch/burn'sgatherfunction, while ONNX'sGatherseems to be equivalent to burn'sselect. In PyTorch, the ONNXGatheris anindex_select, which burn'sselectmore or less seems equivalent to when using 1D indexes.Testing
Added unit tests.