-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print module - implement module display for remaining modules (part2) #1933
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1933 +/- ##
==========================================
+ Coverage 84.56% 85.04% +0.47%
==========================================
Files 793 793
Lines 93859 94590 +731
==========================================
+ Hits 79370 80442 +1072
+ Misses 14489 14148 -341 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one comment, approving in advance! 🙏
linear_inner: Linear<B>, | ||
linear_outer: Linear<B>, | ||
dropout: Dropout, | ||
gelu: Gelu, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should put the parameters public.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. I made other modules' attributes public for consistency since it's been requested frequently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for also fixing the modules parameters and adding docstrings 🙏
Pull Request Template
Checklist
run-checks all
script has been executed.Related Issues/PRs
#1357
Changes
Added the module displays for the following modules:
Testing
Added rendering unit tests for each module.