-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ReduceProd ONNX Import #1955
Conversation
Hi there, hopefully this is all correct. Most seems to be very similar to the other reduce ops anyway. onnx-tests is currently failing with |
Should be better now. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1955 +/- ##
==========================================
+ Coverage 85.04% 85.05% +0.01%
==========================================
Files 793 793
Lines 94583 94724 +141
==========================================
+ Hits 80442 80572 +130
- Misses 14141 14152 +11 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I was just reviewing the PR and your last commit addressed the comments I had.
Thank you 🙏
Checklist
run-checks all
script has been executed.Related Issues/PRs
#1894, #1714
Changes
Adds support for ONNX ReduceProd burn-import in an attempt to understand the structure better.
Testing
cargo test -p burn-import
cargo test -p onnx-tests