Fix warnings when using record-backward-compat
#1977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like a typo was introduced in #1966 (CI didn't run cuz it only affected markdown files).. Seems to have been fixed in other PRs so I'll leave it as is. |
laggui
force-pushed
the
fix/data/backward-compat
branch
from
82938e4 to
95d060b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1977 +/- ##
=======================================
Coverage 85.29% 85.29%
=======================================
Files 798 798
Lines 95512 95512
=======================================
Hits 81471 81471
Misses 14041 14041 ☔ View full report in Codecov by Sentry. |
nathanielsimard
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some small omissions in the tensor data refactor #1916 with the
record-backward-compatfeature flagDataSerialize