Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert compatible prelu weights to rank 1 #2054

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Convert compatible prelu weights to rank 1 #2054

merged 1 commit into from
Jul 23, 2024

Conversation

laggui
Copy link
Member

@laggui laggui commented Jul 23, 2024

Checklist

  • Confirmed that run-checks all script has been executed.

Related Issues/PRs

Fixes #2053

Changes

PRelu alpha weights can have rank > 1. This PR converts compatible weights to rank 1.

Testing

Model in linked issue works.

@laggui laggui requested a review from antimora July 23, 2024 13:40
Copy link
Collaborator

@antimora antimora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for fixing it!

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.

Project coverage is 86.43%. Comparing base (4c73532) to head (74d3af5).

Files Patch % Lines
crates/burn-import/src/onnx/to_burn.rs 44.44% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2054      +/-   ##
==========================================
- Coverage   86.43%   86.43%   -0.01%     
==========================================
  Files         683      683              
  Lines       87245    87253       +8     
==========================================
+ Hits        75410    75413       +3     
- Misses      11835    11840       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@laggui laggui merged commit 53c77ae into main Jul 23, 2024
15 checks passed
@laggui laggui deleted the fix/onnx/prelu branch July 23, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Trouble importing FaceONNX recognizer model
2 participants