Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fusion auto bound checks #2087

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Conversation

nathanielsimard
Copy link
Member

Updating to the new CubeCL version automatically adds an early return when setting the writing strategy. This helps avoid out-of-bound reads and writes, which is especially useful with the fusion backend. It also enables the CUDA runtime to work seamlessly with fusion.

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 86.18%. Comparing base (f673721) to head (d9f500a).
Report is 1 commits behind head on main.

Files Patch % Lines
crates/burn-jit/src/fusion/tracing/builder.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2087      +/-   ##
==========================================
+ Coverage   86.16%   86.18%   +0.02%     
==========================================
  Files         686      687       +1     
  Lines       87871    88187     +316     
==========================================
+ Hits        75717    76008     +291     
- Misses      12154    12179      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nathanielsimard nathanielsimard merged commit 62a30e9 into main Aug 1, 2024
15 checks passed
@nathanielsimard nathanielsimard deleted the fix/fusion-auto-bound-checks branch August 1, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant