Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move conv autotune under feature flag (except key) #2330

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

laggui
Copy link
Member

@laggui laggui commented Oct 2, 2024

Checklist

  • Confirmed that run-checks all script has been executed.

Related Issues/PRs

Stumbled upon this while validating the changes in #2311 with the mnist-inference-web example (using wgpu)

Changes

When autotune feature flag is not used, the autotune key should still be available otherwise its usage in JitAutotuneKey will throw some unresolved import errors.

Testing

Works with mnist-inference-web example on wgpu.

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.37%. Comparing base (99d9fa2) to head (7819571).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2330   +/-   ##
=======================================
  Coverage   85.37%   85.37%           
=======================================
  Files         768      769    +1     
  Lines       98673    98673           
=======================================
  Hits        84238    84238           
  Misses      14435    14435           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@laggui laggui merged commit dce5565 into main Oct 2, 2024
11 checks passed
@laggui laggui deleted the fix/jit/autotune-vis branch October 2, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant