Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix autodiff memory leak #2347

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Fix autodiff memory leak #2347

merged 2 commits into from
Oct 9, 2024

Conversation

nathanielsimard
Copy link
Member

Fix #2333

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.38%. Comparing base (ebe2421) to head (584dbdb).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2347   +/-   ##
=======================================
  Coverage   85.38%   85.38%           
=======================================
  Files         770      770           
  Lines       98899    98909   +10     
=======================================
+ Hits        84441    84451   +10     
  Misses      14458    14458           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AsherJingkongChen
Copy link
Contributor

AsherJingkongChen commented Oct 8, 2024

LGTM, no leak is detected by Apple's Instruments.app in MWE of #2333 when using Autodiff<NdArray> as the backend.

Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On top of the tests we did yesterday, I just validated that the CIFAR example still converges and checked the map length + capacity over a training. Both look good! 😎

@laggui laggui merged commit 0592af0 into main Oct 9, 2024
11 checks passed
@laggui laggui deleted the fix/autodiff-memory-leak branch October 9, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Heap memory leak from AutodiffTensor
3 participants