Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add burn-hip #2399

Merged
merged 6 commits into from
Oct 24, 2024
Merged

Add burn-hip #2399

merged 6 commits into from
Oct 24, 2024

Conversation

syl20bnr
Copy link
Member

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

N/A

Changes

Adds a new backend using cubecl-hip runtime.

Testing

On a system with a compatible AMD GPU.

export CUBECL_ROCM_PATH=/opt/rocm
cd crates/burn-hip
cargo test

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.25%. Comparing base (80c831b) to head (995efec).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2399      +/-   ##
==========================================
- Coverage   85.26%   85.25%   -0.01%     
==========================================
  Files         792      792              
  Lines      104516   104552      +36     
==========================================
+ Hits        89115    89141      +26     
- Misses      15401    15411      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@nathanielsimard nathanielsimard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nathanielsimard nathanielsimard merged commit 6678f79 into main Oct 24, 2024
11 checks passed
@nathanielsimard nathanielsimard deleted the hip-backend branch October 24, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants