Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend tensor operations #2413

Merged
merged 6 commits into from
Oct 25, 2024
Merged

Conversation

tsanona
Copy link
Contributor

@tsanona tsanona commented Oct 23, 2024

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Changes

Add some new tensor operations for convenience.

Testing

New function argtopk is tested on doc, other functions use already existing functions.

Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition for the one_hot method, but I would not add argtopk (unnecessary). 👍

Thanks for fixing all the typos at the same time 😄

burn-book/src/building-blocks/tensor.md Outdated Show resolved Hide resolved
burn-book/src/building-blocks/tensor.md Outdated Show resolved Hide resolved
burn-book/src/building-blocks/tensor.md Outdated Show resolved Hide resolved
crates/burn-tensor/src/tensor/api/int.rs Outdated Show resolved Hide resolved
crates/burn-tensor/src/tensor/api/numeric.rs Outdated Show resolved Hide resolved
@laggui laggui mentioned this pull request Oct 25, 2024
2 tasks
Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Just one minor thing you missed in the book API

/edit: might have to resolve some conflicts from main

burn-book/src/building-blocks/tensor.md Outdated Show resolved Hide resolved
# Conflicts:
#	burn-book/src/building-blocks/tensor.md
#	crates/burn-tensor/src/tensor/api/int.rs
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 21.05263% with 30 lines in your changes missing coverage. Please review.

Project coverage is 85.29%. Comparing base (d5e8e31) to head (c48037a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/burn-tensor/src/tensor/api/check.rs 4.76% 20 Missing ⚠️
crates/burn-tensor/src/tensor/api/int.rs 0.00% 7 Missing ⚠️
crates/burn-tensor/src/tensor/api/numeric.rs 66.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2413      +/-   ##
==========================================
- Coverage   85.32%   85.29%   -0.03%     
==========================================
  Files         792      792              
  Lines      104455   104479      +24     
==========================================
- Hits        89124    89118       -6     
- Misses      15331    15361      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@laggui laggui merged commit 2775ec3 into tracel-ai:main Oct 25, 2024
11 checks passed
@laggui
Copy link
Member

laggui commented Oct 25, 2024

Awesome 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants