-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend tensor operations #2413
Extend tensor operations #2413
Conversation
…ons, correct some docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great addition for the one_hot
method, but I would not add argtopk
(unnecessary). 👍
Thanks for fixing all the typos at the same time 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Just one minor thing you missed in the book API
/edit: might have to resolve some conflicts from main
# Conflicts: # burn-book/src/building-blocks/tensor.md # crates/burn-tensor/src/tensor/api/int.rs
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2413 +/- ##
==========================================
- Coverage 85.32% 85.29% -0.03%
==========================================
Files 792 792
Lines 104455 104479 +24
==========================================
- Hits 89124 89118 -6
- Misses 15331 15361 +30 ☔ View full report in Codecov by Sentry. |
Awesome 🙏 |
Pull Request Template
Checklist
run-checks all
script has been executed.Changes
Add some new tensor operations for convenience.
Testing
New function
argtopk
is tested on doc, other functions use already existing functions.