Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning in docstring for indices bound checks #2462

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

laggui
Copy link
Member

@laggui laggui commented Nov 4, 2024

Checklist

  • Confirmed that run-checks all script has been executed.

Related Issues/PRs

As noted on discord:
https://discord.com/channels/1038839012602941528/1059209073784008835/1300397078744268821
https://discord.com/channels/1038839012602941528/1059209073784008835/1302692777741520979

Changes

Added a warning to the docstring for tensor methods where indices runtime bound checks are not guaranteed.

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.29%. Comparing base (03e4df3) to head (e92c719).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2462      +/-   ##
==========================================
- Coverage   85.29%   85.29%   -0.01%     
==========================================
  Files         793      793              
  Lines      104645   104645              
==========================================
- Hits        89260    89259       -1     
- Misses      15385    15386       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nathanielsimard nathanielsimard merged commit c3549fb into main Nov 6, 2024
11 checks passed
@nathanielsimard nathanielsimard deleted the fix/tensor/indices-bounds-docs branch November 6, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants