Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async Processor #2482

Merged
merged 6 commits into from
Nov 14, 2024
Merged

Async Processor #2482

merged 6 commits into from
Nov 14, 2024

Conversation

nathanielsimard
Copy link
Member

Run the metrics & dashboard on another thread.

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 3.77358% with 51 lines in your changes missing coverage. Please review.

Project coverage is 82.87%. Comparing base (c7233bf) to head (ec08222).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...s/burn-train/src/metric/processor/async_wrapper.rs 0.00% 23 Missing ⚠️
crates/burn-train/src/metric/iteration.rs 0.00% 20 Missing ⚠️
crates/burn-train/src/learner/builder.rs 0.00% 7 Missing ⚠️
crates/burn-train/src/metric/processor/full.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2482      +/-   ##
==========================================
- Coverage   82.91%   82.87%   -0.04%     
==========================================
  Files         812      814       +2     
  Lines      105334   105383      +49     
==========================================
+ Hits        87336    87338       +2     
- Misses      17998    18045      +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Some(val) => metadata.iteration as f64 / val.elapsed().as_secs_f64(),
None => {
self.instant = Some(std::time::Instant::now());
0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@laggui laggui merged commit bff67dc into main Nov 14, 2024
9 checks passed
@laggui laggui deleted the perf/async-processor branch November 14, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants