Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cast float test precision #2586

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Fix cast float test precision #2586

merged 1 commit into from
Dec 9, 2024

Conversation

laggui
Copy link
Member

@laggui laggui commented Dec 3, 2024

Related Issues/PRs

As correctly pointed out on discord, this test will always fail if we cast from f16 or bf16 which have a lower precision.

Changes

Changed the precision tolerance.

Testing

Tested on cuda backend with f16 and bf16 (with bf16 having the lowest precision).

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.86%. Comparing base (6aa470b) to head (c5179ee).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2586   +/-   ##
=======================================
  Coverage   81.86%   81.86%           
=======================================
  Files         833      833           
  Lines      106465   106465           
=======================================
  Hits        87162    87162           
  Misses      19303    19303           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@laggui laggui merged commit 19975e9 into main Dec 9, 2024
11 checks passed
@laggui laggui deleted the fix/cast/precision branch December 9, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant