Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change pad value w/ ElementConversion #2653

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Change pad value w/ ElementConversion #2653

merged 1 commit into from
Jan 3, 2025

Conversation

laggui
Copy link
Member

@laggui laggui commented Jan 3, 2025

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

Following this discord comment

Changes

Changed tensor.pad(...) pad value argument to accept E: ElementConversion (like the other APIs such as Tensor::full(...), which is used by tensor.pad).

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.84%. Comparing base (d9418ad) to head (9b75388).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2653   +/-   ##
=======================================
  Coverage   81.84%   81.84%           
=======================================
  Files         838      838           
  Lines      107488   107488           
=======================================
  Hits        87975    87975           
  Misses      19513    19513           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@laggui laggui merged commit 2338912 into main Jan 3, 2025
11 checks passed
@laggui laggui deleted the fix/pad/args branch January 3, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant