Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/cubecl #2654

Merged
merged 13 commits into from
Jan 5, 2025
Merged

Refactor/cubecl #2654

merged 13 commits into from
Jan 5, 2025

Conversation

nathanielsimard
Copy link
Member

@nathanielsimard nathanielsimard commented Jan 4, 2025

Update to the new cubecl version and fix breaking changes.

Reduces a lot compilation time.

Copy link

codecov bot commented Jan 5, 2025

Codecov Report

Attention: Patch coverage is 52.40964% with 158 lines in your changes missing coverage. Please review.

Project coverage is 83.14%. Comparing base (7a19b5f) to head (407753c).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...tes/burn-jit/src/kernel/conv/conv2d/gemm/launch.rs 0.00% 57 Missing ⚠️
...it/src/kernel/conv/conv2d/gemm/homogeneous/base.rs 36.84% 24 Missing ⚠️
crates/burn-jit/src/fusion/matmul/args.rs 0.00% 16 Missing ⚠️
crates/burn-jit/src/fusion/matmul/optimization.rs 58.62% 12 Missing ⚠️
crates/burn-jit/src/kernel/comparison.rs 38.46% 8 Missing ⚠️
crates/burn-jit/src/kernel/reduce/naive/kernel.rs 30.00% 7 Missing ⚠️
crates/burn-jit/src/kernel/binary.rs 53.84% 6 Missing ⚠️
crates/burn-jit/src/kernel/pool/max_pool2d.rs 25.00% 6 Missing ⚠️
...s/burn-jit/src/kernel/conv/conv2d/implicit_gemm.rs 69.23% 4 Missing ⚠️
...urn-jit/src/kernel/conv/conv2d/gemm/loader/bias.rs 0.00% 3 Missing ⚠️
... and 13 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2654      +/-   ##
==========================================
+ Coverage   81.84%   83.14%   +1.29%     
==========================================
  Files         838      839       +1     
  Lines      107487   107913     +426     
==========================================
+ Hits        87975    89719    +1744     
+ Misses      19512    18194    -1318     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nathanielsimard nathanielsimard merged commit 675b63e into main Jan 5, 2025
11 checks passed
@nathanielsimard nathanielsimard deleted the refactor/cubecl branch January 5, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant