Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't mention a fixed candle bug #2689

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

kitterion
Copy link
Contributor

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Changes

While reading the burn book, I noticed that it mentions a candle bug that has been fixed for almost a year.
Remove the mention in the book and tests.

Testing

I ran the corresponding tests locally.

Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that 😄

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.92%. Comparing base (51b742f) to head (1f155e6).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2689   +/-   ##
=======================================
  Coverage   82.91%   82.92%           
=======================================
  Files         843      843           
  Lines      107431   107427    -4     
=======================================
+ Hits        89081    89087    +6     
+ Misses      18350    18340   -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@laggui laggui merged commit ad89dcc into tracel-ai:main Jan 13, 2025
11 checks passed
@kitterion kitterion deleted the do-not-mention-fixed-bug branch January 13, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants