-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(openai): streaming tool_call + logging multiple tool_call #463
Conversation
…s, allow multiple tool calls
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Left a small nit comment
} | ||
} | ||
} | ||
// if (chunk.choices[0]?.delta.tool_calls) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All done thanks!
@nirga just a note, this will break anyone's code which uses |
@guillaumefontan I think we should match the way we've implemented this on Python - So it should be Also note the CI is broken on your PR |
Hi @nirga I've updated to tool_calls and fixed the lint warnings. However the build error: |
d51fdbd
to
f27352a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay here, working on fixing the CI now. LGTM except for that!
f27352a
to
66513fd
Compare
66513fd
to
c696b10
Compare
Fixes #464 and #465