INSTA-26613 milvustestcases

traceloop · Feb 26, 2025 · 07b1144 · 07b1144
1 parent 28f547e
commit 07b1144
Showing 1 changed file with 13 additions and 21 deletions.
diff --git a/packages/opentelemetry-instrumentation-milvus/tests/test_query.py b/packages/opentelemetry-instrumentation-milvus/tests/test_query.py
@@ -196,24 +196,23 @@ def test_milvus_query_and(exporter, collection):
         _id = event.attributes.get("id")
         assert isinstance(tag, str)
         assert isinstance(_id, int)
-        
-        
+
+
 def test_milvus_create_collection(exporter, collection):
     collection_name = "quick_setup"
     milvus.create_collection(
-    collection_name=collection_name,
-    dimension=5,
-    primary_field_name="my_id",
-    id_type="string",
-    vector_field_name="my_vector",
-    metric_type="L2",
-    auto_id=True,
-    max_length=512,
-    timeout=10
+        collection_name=collection_name,
+        dimension=5,
+        primary_field_name="my_id",
+        id_type="string",
+        vector_field_name="my_vector",
+        metric_type="L2",
+        auto_id=True,
+        max_length=512,
+        timeout=10
     )
-    insert_data(collection_name)
     spans = exporter.get_finished_spans()
-    span = next(span for span in spans if span.name == "milvus.query")
+    span = next(span for span in spans if span.name == "milvus.create_collection")
 
     assert span.attributes.get(SpanAttributes.VECTOR_DB_VENDOR) == "milvus"
     assert span.attributes.get(SpanAttributes.VECTOR_DB_OPERATION) == "create_collection"
@@ -226,11 +225,4 @@ def test_milvus_create_collection(exporter, collection):
     assert span.attributes.get(SpanAttributes.MILVUS_CREATE_COLLECTION_TIMEOUT) == 10
     assert span.attributes.get(SpanAttributes.MILVUS_CREATE_COLLECTION_PRIMARY_FIELD) == "my_id"
     assert span.attributes.get(SpanAttributes.MILVUS_CREATE_COLLECTION_VECTOR_FIELD) == "my_vector"
-    events = span.events
-    for event in events:
-        assert event.name == Events.DB_QUERY_RESULT.value
-        tag = event.attributes.get("color_tag")
-        _id = event.attributes.get("id")
-        assert isinstance(tag, str)
-        assert isinstance(_id, int)
-    print("completed")
+