fix(openai): not given values thrown errors (#1876)

traceloop · Aug 24, 2024 · 3aa9d69 · 3aa9d69
1 parent 13b0707
commit 3aa9d69
Show file tree

Hide file tree

Showing 5 changed files with 1,627 additions and 1,309 deletions.
diff --git a/...ntelemetry-instrumentation-openai/opentelemetry/instrumentation/openai/shared/__init__.py b/...ntelemetry-instrumentation-openai/opentelemetry/instrumentation/openai/shared/__init__.py
@@ -33,10 +33,8 @@ def should_send_prompts():
 
 
 def _set_span_attribute(span, name, value):
-    if value is not None:
-        if value != "":
-            span.set_attribute(name, value)
-    return
+    if value is not None and value != "" and value != openai.NOT_GIVEN:
+        span.set_attribute(name, value)
 
 
 def _set_client_attributes(span, instance):