New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(openai): handle empty finish_reason #1236

Merged

nirga merged 1 commit into main from empty-finish-reason

Jun 5, 2024

Member

nirga commented Jun 5, 2024 •

edited

Loading

Fixes #1235

I have added tests that cover my changes.
If adding a new instrumentation or changing an existing one, I've added screenshots from some observability platform showing the change.
PR name follows conventional commits format: feat(instrumentation): ... or fix(instrumentation): ....
(If applicable) I have updated the documentation accordingly.


          fix(openai): handle empty finish_reason

9887d8a

nirga requested a review from galkleinman

June 5, 2024 08:42

galkleinman approved these changes

View reviewed changes

nirga merged commit e79394e into main

8 checks passed

nirga deleted the empty-finish-reason branch

June 5, 2024 10:47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet