Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alephalpha): Add AlephAlpha instrumentation #1285

Merged
merged 2 commits into from
Jun 9, 2024

Conversation

Benedikt-Wolf
Copy link
Contributor

Added support for Aleph Alpha's python client. Currently only for synchronous completions.

  • I have added tests that cover my changes.
  • If adding a new instrumentation or changing an existing one, I've added screenshots from some observability platform showing the change.
  • PR name follows conventional commits format: feat(instrumentation): ... or fix(instrumentation): ....
  • (If applicable) I have updated the documentation accordingly.

Sync completion only
Copy link
Member

@nirga nirga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @Benedikt-Wolf! Left a couple of small comments

instrumentor.instrument()
return True
except Exception as e:
logging.error(f"Error initializing TogetherAI instrumentor: {e}")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AlephAlpha


def init_alephalpha_instrumentor():
try:
if importlib.util.find_spec("alephalpha") is not None:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the name of the package alephalpha-client?

Copy link
Contributor Author

@Benedikt-Wolf Benedikt-Wolf Jun 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overlooked that, my bad. I changed it to "aleph_alpha_client".

Changed to correct client name.
@nirga nirga merged commit 3d230c6 into traceloop:main Jun 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants