Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(openai): Handle tool_calls assistant messages #1429

Merged
merged 3 commits into from
Jul 2, 2024
Merged

fix(openai): Handle tool_calls assistant messages #1429

merged 3 commits into from
Jul 2, 2024

Conversation

achang97
Copy link
Contributor

@achang97 achang97 commented Jul 1, 2024

#1428

  • I have added tests that cover my changes.
  • If adding a new instrumentation or changing an existing one, I've added screenshots from some observability platform showing the change.
  • PR name follows conventional commits format: feat(instrumentation): ... or fix(instrumentation): ....
  • (If applicable) I have updated the documentation accordingly.

nirga
nirga reviewed Jul 2, 2024
View reviewed changes
Copy link
Member

@nirga nirga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @achang97! Can you rebase this?

@nirga nirga merged commit 47a4a88 into traceloop:main Jul 2, 2024
8 checks passed
@achang97 achang97 deleted the tool-calls branch July 2, 2024 22:09
@nirga nirga mentioned this pull request Jul 4, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nirga nirga nirga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achang97 @nirga