New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: association properties and workflow / task on metrics #1494

Merged

nirga merged 2 commits into main from workflows-in-metrics

Jul 9, 2024

Member

nirga commented Jul 9, 2024

I have added tests that cover my changes.
If adding a new instrumentation or changing an existing one, I've added screenshots from some observability platform showing the change.
PR name follows conventional commits format: feat(instrumentation): ... or fix(instrumentation): ....
(If applicable) I have updated the documentation accordingly.

nirga force-pushed the workflows-in-metrics branch from 7c73c33 to 659c88f Compare

July 9, 2024 12:30


          fix: associaton properties and workflow / task on metrics

d28ce0d

nirga force-pushed the workflows-in-metrics branch from 659c88f to d28ce0d Compare

July 9, 2024 13:31

galkleinman approved these changes

View reviewed changes

Contributor

galkleinman left a comment

Much cleaner than I thought.

I would omit the "common" from "common_attributes" everywhere, as it doesn't provide any additional info imo.


          Merge branch 'main' into workflows-in-metrics

91bbf2e

nirga merged commit 2f9f163 into main

8 checks passed

nirga deleted the workflows-in-metrics branch

July 9, 2024 16:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet