feat: LanceDB Integration #1749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Very basic LanceDB integration for table operations. synchronous only.
nirga
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Thanks @Benedikt-Wolf! Mind rebasing and fixing the merge conflict?
|
|
||
| assert span.attributes.get(SpanAttributes.VECTOR_DB_VENDOR) == "lancedb" | ||
| assert span.attributes.get(SpanAttributes.VECTOR_DB_OPERATION) == "add" | ||
| assert span.attributes.get(SpanAttributes.MILVUS_INSERT_DATA_COUNT) == 2 |
There was a problem hiding this comment.
Hmm... We don't have a generic one for this? :(
There was a problem hiding this comment.
I don't think so right now, but I'd be happy to discuss how we can genericize VectorDB Operations without losing the small semantic differences between providers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very basic LanceDB integration for table operations. synchronous only.
#241
feat(instrumentation): ...orfix(instrumentation): ....