-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk): chained entity path on nested tasks #1782
feat(sdk): chained entity path on nested tasks #1782
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a breaking change, let's wait with it for later this week as I want to release a small fix today.
Left a nit comment
@@ -10,65 +10,32 @@ | |||
Traceloop.init(app_name="joke_generation_service") | |||
|
|||
|
|||
@task(name="joke_creation", version=1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you delete this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I copied this file from Gal branch, I just saw he excluded it from his merged PR, so I'll remove this change as well 🙈
feat(instrumentation): ...
orfix(instrumentation): ...
.Example
Assuming we have a workflow with three nesting levels of tasks
The expected entity paths will be
some_workflow
path is Noneouter_task
path is 'outer_task'inner_task
path is 'outer_task.inner_task'inner_inner_task
path is 'outer_task.inner_task.inner_inner_task'