fix(sdk): support a "block-list" of things to not instrument #1958
Conversation
dosubot
bot
added
the
size:S
|
|
dosubot
bot
added
new instrumentation
python
|
One more note, if someone specifically asks for requests package instrument, I'm not considering the disable behavior. |
| @@ -62,6 +62,7 @@ class TracerWrapper(object): | |||
| def __new__( | |||
| cls, | |||
| disable_batch=False, | |||
| disable_requests_instrumentation=True, | |||
There was a problem hiding this comment.
this seems highly specific, don't you think? I think I'd rather add something like the "instruments" parameter but that can be sort of a "block list" where any of the libraries in that parameter won't be instrumented.
There was a problem hiding this comment.
Block list sounds like a better idea. The reason I went specific was because the tracer is normally expected to instrument GenAI-related packages, but has requests as a special additional scenario. Block list would be broad enough for future developments as well.
dosubot
bot
added
size:L
nirga
changed the title
requests package by default
| init_marqo_instrumentor() | ||
| init_lancedb_instrumentor() | ||
| init_groq_instrumentor() | ||
| def init_instrumentations(should_enrich_metrics: bool, block_instruments: Optional[Set[Instruments]] = None): |
There was a problem hiding this comment.
ideally this might be an opportunity to combine these 2 ways and just have init_instrumentations work the same as the if instruments is not None clause - just set all instrumentations as the value of instruments. WDYT?
| @@ -44,6 +44,7 @@ def init( | |||
| api_key: str = None, | |||
| headers: Dict[str, str] = {}, | |||
| disable_batch=False, | |||
| disable_requests_instrumentation: bool = True, | |||
nirga
force-pushed
the
disable-requests-instrumentation
branch
4 times, most recently
from
7c830ba
to
bf4c0c1
Compare
nirga
force-pushed
the
disable-requests-instrumentation
branch
from
bf4c0c1
to
5607c9b
Compare
I have added tests that cover my changes.
Need help here. There are no specific tests checking for
requests. Where should I add the test?If adding a new instrumentation or changing an existing one, I've added screenshots from some observability platform showing the change.
Could you give a recommendation on how to do this with our
HoneyHiveTracer?Is there a particular example script that would work?
feat(instrumentation): ...orfix(instrumentation): ....TBD, once the tests are running