Skip to content

enhancement(create_metrics_refactor) #1998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

enhancement(create_metrics_refactor) #1998

wants to merge 9 commits into from

Conversation

@ishaanagw
Copy link

@ishaanagw ishaanagw commented Sep 21, 2024 •
edited
Loading

  • I have added tests that cover my changes.
  • If adding a new instrumentation or changing an existing one, I've added screenshots from some observability platform showing the change.
  • PR name follows conventional commits format: feat(instrumentation): ... or fix(instrumentation): ....
  • (If applicable) I have updated the documentation accordingly.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 21, 2024
@CLAassistant
Copy link

CLAassistant commented Sep 21, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@dosubot dosubot bot added enhancement New feature or request python Pull requests that update Python code labels Sep 21, 2024
nirga
nirga reviewed Sep 21, 2024
View reviewed changes
Copy link
Member

@nirga nirga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is what I was aiming for :) I think we also have it in Anthropic

@ishaanagw
Copy link
Author

What are the next steps @nirga ?

@ishaanagw
Copy link
Author

Are the changes good to be merged ?

@ishaanagw ishaanagw requested a review from nirga October 5, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nirga nirga Awaiting requested review from nirga

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

enhancement New feature or request python Pull requests that update Python code size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ishaanagw @CLAassistant @nirga