feat(SageMaker): Add SageMaker instrumentation #2028
Conversation
dosubot
bot
added
the
size:XL
|
|
dosubot
bot
added
new instrumentation
python
There was a problem hiding this comment.
Thanks so much @bobbywlindsey! Looking good :)
Left a couple of small comments
| @@ -0,0 +1,33 @@ | |||
| # OpenTelemetry Bedrock Instrumentation | |||
|
|
|||
| <a href="https://pypi.org/project/opentelemetry-instrumentation-bedrock/"> | |||
There was a problem hiding this comment.
nit
| <a href="https://pypi.org/project/opentelemetry-instrumentation-bedrock/"> | |
| <a href="https://pypi.org/project/opentelemetry-instrumentation-sagemaker/"> |
There was a problem hiding this comment.
Ah totally missed this file, thanks for the catch. Will update.
| from opentelemetry.instrumentation.sagemaker.streaming_wrapper import StreamingWrapper | ||
| from opentelemetry.instrumentation.sagemaker.utils import dont_throw | ||
| from wrapt import wrap_function_wrapper | ||
| import anthropic |
There was a problem hiding this comment.
Ah nope, I'll remove it 👍🏻
|
|
||
| _set_span_attribute(span, SpanAttributes.LLM_REQUEST_MODEL, endpoint_name) | ||
| _set_span_attribute( | ||
| span, SpanAttributes.LLM_SAGEMAKER_REQUEST, json.dumps(request_body) |
There was a problem hiding this comment.
I think I might use our "input" and "output" attributes instead:
(these will anyway be refactored to be logs in the near future as per decisions we're making at the otel semantic conventions WG)
There was a problem hiding this comment.
SGTM, will make the updates.
| opentelemetry-instrumentation = "^0.48b0" | ||
| opentelemetry-semantic-conventions = "^0.48b0" | ||
| opentelemetry-semantic-conventions-ai = "0.4.1" | ||
| anthropic = ">=0.17.0" |
There was a problem hiding this comment.
shouldn't be a dependency of the package
|
@bobbywlindsey looks like you need to run |
|
@bobbywlindsey seems like tests are failing - I think you'll need to amend the cassettes or the mock API URL you're using |
|
@nirga Thanks for the help :) I think I've resolved the build issues now. Let me know if there's anything else I can do to improve the PR. Once this one is merged, I'll begin working on Bedrock Knowledge Bases and Agents issues 👍🏻 |
feat(instrumentation): ...orfix(instrumentation): ....Summary of changes (closes #1660):
llm.sagemaker.requestwhich captures the request body of the endpoint invocationllm.sagemaker.responsewhich captures the response body of the endpoint invocation