fix(instrumentation): replace api base url hardcoded value from watsonx #2173
Conversation
dosubot
bot
added
the
size:S
|
|
There was a problem hiding this comment.
Thanks @rajmanna-dev! Left a small comment. Can you sign the CLA?
There was a problem hiding this comment.
@rajmanna-dev note that CI is failing - I think it's related to the import you added
| @@ -14,6 +14,7 @@ | |||
| from opentelemetry.trace.status import Status, StatusCode | |||
| from opentelemetry.metrics import get_meter | |||
| from opentelemetry.metrics import Counter, Histogram | |||
| from sample-app.sample_app.watsonx-langchain import watsonx_llm_init | |||
| @@ -101,10 +102,15 @@ def _set_span_attribute(span, name, value): | |||
|
|
|||
|
|
|||
| def _set_api_attributes(span): | |||
| watsonx_llm = watsonx_llm_init() | |||
There was a problem hiding this comment.
How can i extract url directly from WatsonxLLM objcet.
There was a problem hiding this comment.
See the comment here I shared an example of how we've done it elsewhere - #2165 (review)
There was a problem hiding this comment.
Should i check the attribute 'url' of the instance and then set that to api_base_url variable.
Like:
if hasattr(instance, "url"):
api_base_url = instance.urlThere was a problem hiding this comment.
Have you checked that the instance can actually have this attribute? I'd run one of the sample apps and see
dosubot
bot
added
size:XS
rajmanna-dev
deleted the
fix-2163-replace-api-base-url-hardcoded-value
branch
Fixed #2163
I am a beginner in learning python, I don't know how to make or add test for this changes. I need guidence.
feat(instrumentation): ...orfix(instrumentation): ....