Skip to content

Conversation

smit23patel
Copy link

  1. Type Hints: Added type hints to function signatures for better clarity and type checking.

  2. Optional Parameters: Used Optional for parameters that can be None, improving the understanding of the function's expected input.

  • I have added tests that cover my changes.
  • If adding a new instrumentation or changing an existing one, I've added screenshots from some observability platform showing the change.
  • PR name follows conventional commits format: feat(instrumentation): ... or fix(instrumentation): ....
  • (If applicable) I have updated the documentation accordingly.

1. Type Hints: Added type hints to function signatures for better clarity and type checking.

2. Optional Parameters: Used Optional for parameters that can be None, improving the understanding of the function's expected input.
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 21, 2024
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@dosubot dosubot bot added the python Pull requests that update Python code label Oct 21, 2024
Copy link
Member

@nirga nirga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @smit23patel, but if you're adding type hints - let's add the right ones! Can you replace the Any with the right classes from the appropriate libraries?

Copy link

gitguardian bot commented Oct 24, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
10447429 Triggered Generic High Entropy Secret 9160e4d packages/traceloop-sdk/traceloop/sdk/telemetry.py View secret
14250362 Triggered Generic High Entropy Secret 9160e4d packages/traceloop-sdk/traceloop/sdk/telemetry.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python Pull requests that update Python code size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants