Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(openai+anthropic): async call crashing the app when already in a running asyncio loop #2226

Merged
merged 6 commits into from
Oct 29, 2024
Merged

fix(openai+anthropic): async call crashing the app when already in a running asyncio loop #2226

merged 6 commits into from
Oct 29, 2024

Conversation

galkleinman
Copy link
Contributor

fixes: #2195

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working python Pull requests that update Python code labels Oct 29, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 29, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Oct 29, 2024
@galkleinman galkleinman merged commit 2355123 into main Oct 29, 2024
9 checks passed
@jp-agenta
Copy link

Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nirga nirga nirga approved these changes

Assignees
No one assigned
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer python Pull requests that update Python code size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Adding asyncio.run() in 0.31.3 makes the package fail when run from within async
3 participants
@galkleinman @jp-agenta @nirga