Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): don't serialize large jsons as inputs/outputs #2252

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

nirga
Copy link
Member

@nirga nirga commented Nov 4, 2024

  • I have added tests that cover my changes.
  • If adding a new instrumentation or changing an existing one, I've added screenshots from some observability platform showing the change.
  • PR name follows conventional commits format: feat(instrumentation): ... or fix(instrumentation): ....
  • (If applicable) I have updated the documentation accordingly.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 4, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 4, 2024
@nirga nirga merged commit d30ba8f into main Nov 4, 2024
9 checks passed
@nirga nirga deleted the dont-serialize-large branch November 4, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants