Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): gemini instrumentation was never installed due to package name error #2288

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

nirga
Copy link
Member

@nirga nirga commented Nov 9, 2024

Fixes #2140

  • I have added tests that cover my changes.
  • If adding a new instrumentation or changing an existing one, I've added screenshots from some observability platform showing the change.
  • PR name follows conventional commits format: feat(instrumentation): ... or fix(instrumentation): ....
  • (If applicable) I have updated the documentation accordingly.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Nov 9, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 9, 2024
@nirga nirga merged commit 4fdf007 into main Nov 9, 2024
9 checks passed
@nirga nirga deleted the gemini-wrong-import branch November 9, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: Google Instrumentation does not work
2 participants