feat(sdk): client, annotations #2452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced a new static method `report_labeling` in the Traceloop class to facilitate reporting labeling data with detailed parameters. - Enhanced type hints across the SDK, including the use of `Optional` for several parameters and improved type definitions for API requests. - Updated the Fetcher class to support posting to a new API endpoint with better error handling. - Refactored existing code for clarity and consistency, including adjustments to environment variable handling and method signatures.
dosubot
bot
added
size:L
galkleinman
reviewed
Jan 6, 2025
| signature = generate_signature(pirate_joke) | ||
| print(pirate_joke + "\n\n" + signature) | ||
|
|
||
| Traceloop.get().annotation.create( |
Contributor
There was a problem hiding this comment.
Suggested change
| Traceloop.get().annotation.create( | |
| client = Traceloop.get() | |
| client.annotation.create( |
just for the mental model of creating a client (and stop using this static impl)
galkleinman
approved these changes
Jan 9, 2025
nina-kollman
pushed a commit
that referenced
this pull request
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[BREAKING] Remove
report_scoreIntroduce
ClientAdd
user_feedbackfunctionalityI have added tests that cover my changes.
If adding a new instrumentation or changing an existing one, I've added screenshots from some observability platform showing the change.
PR name follows conventional commits format:
feat(instrumentation): ...orfix(instrumentation): ....(If applicable) I have updated the documentation accordingly.