-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: google-vertexai-instrumentation #289
Conversation
@nirga Gemini Trace: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for this! In addition to the comments, you don't seem to instrument the chat API. Also, please make sure to test actual span attributes and not just the existence of spans.
...es/opentelemetry-instrumentation-vertexai/opentelemetry/instrumentation/vertexai/__init__.py
Outdated
Show resolved
Hide resolved
...es/opentelemetry-instrumentation-vertexai/opentelemetry/instrumentation/vertexai/__init__.py
Outdated
Show resolved
Hide resolved
...es/opentelemetry-instrumentation-vertexai/opentelemetry/instrumentation/vertexai/__init__.py
Outdated
Show resolved
Hide resolved
...es/opentelemetry-instrumentation-vertexai/opentelemetry/instrumentation/vertexai/__init__.py
Outdated
Show resolved
Hide resolved
...es/opentelemetry-instrumentation-vertexai/opentelemetry/instrumentation/vertexai/__init__.py
Outdated
Show resolved
Hide resolved
@nirga Couldn't get model_name in the response and unable to find a way to correlate between model initialisation and the predict function call. Apart from the model_name other issues were resolved and pushed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When trying to run poetry install
I'm getting -
Warning: poetry.lock is not consistent with pyproject.toml. You may be getting improper dependencies. Run poetry lock [--no-update]
to fix it.
Because traceloop-sdk depends on google-cloud-aiplatform (^1.38.1) which doesn't match any versions, version solving failed.
packages/sample-app/pyproject.toml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When trying to run poetry install
I'm getting -
Warning: poetry.lock is not consistent with pyproject.toml. You may be getting improper dependencies. Run poetry lock [--no-update]
to fix it.
Because traceloop-sdk depends on google-cloud-aiplatform (^1.38.1) which doesn't match any versions, version solving failed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing lock file
...es/opentelemetry-instrumentation-vertexai/opentelemetry/instrumentation/vertexai/__init__.py
Outdated
Show resolved
Hide resolved
@nirga pushed the model_name solution |
afddbe0
to
773ca1d
Compare
94d7902
to
801b839
Compare
801b839
to
92ab5c4
Compare
closes #249
/claim #249