Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: google-vertexai-instrumentation #289

Merged
merged 35 commits into from
Jan 11, 2024

Conversation

5war00p
Copy link
Contributor

@5war00p 5war00p commented Dec 25, 2023

closes #249
/claim #249

@5war00p
Copy link
Contributor Author

5war00p commented Dec 25, 2023

@nirga Gemini Trace:

image image image image

Copy link
Member

@nirga nirga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this! In addition to the comments, you don't seem to instrument the chat API. Also, please make sure to test actual span attributes and not just the existence of spans.

@5war00p
Copy link
Contributor Author

5war00p commented Jan 2, 2024

@nirga Couldn't get model_name in the response and unable to find a way to correlate between model initialisation and the predict function call. Apart from the model_name other issues were resolved and pushed.

@5war00p 5war00p requested a review from nirga January 2, 2024 09:16
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When trying to run poetry install I'm getting -

Warning: poetry.lock is not consistent with pyproject.toml. You may be getting improper dependencies. Run poetry lock [--no-update] to fix it.

Because traceloop-sdk depends on google-cloud-aiplatform (^1.38.1) which doesn't match any versions, version solving failed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When trying to run poetry install I'm getting -

Warning: poetry.lock is not consistent with pyproject.toml. You may be getting improper dependencies. Run poetry lock [--no-update] to fix it.

Because traceloop-sdk depends on google-cloud-aiplatform (^1.38.1) which doesn't match any versions, version solving failed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Its taking so longer when i try to add google-cloud-aiplatform using poetry.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing lock file

@5war00p
Copy link
Contributor Author

5war00p commented Jan 4, 2024

@nirga pushed the model_name solution

@5war00p 5war00p requested a review from nirga January 4, 2024 16:06
@5war00p 5war00p requested a review from nirga January 11, 2024 06:22
@nirga nirga force-pushed the vertexai-instrumentation branch from afddbe0 to 773ca1d Compare January 11, 2024 08:55
@nirga nirga force-pushed the vertexai-instrumentation branch 3 times, most recently from 94d7902 to 801b839 Compare January 11, 2024 12:08
@nirga nirga force-pushed the vertexai-instrumentation branch from 801b839 to 92ab5c4 Compare January 11, 2024 12:11
@nirga nirga merged commit 61908c9 into traceloop:main Jan 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: VertexAI Instrumentation
2 participants