feat: support both new and legacy llama_index versions #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update import logic to dynamically support both new (`llama_index.core.llms`) and legacy (`llama_index.legacy.llms.custom`) versions of the `llama_index` package. This change ensures compatibility across different versions of the package by using conditional imports and adjusting `MODULE_NAME` dynamically based on the available version. This improvement enhances the flexibility and maintainability of the codebase when working with the evolving `llama_index` library.
|
|
|
Cool, thanks @alex-feel! |
nirga
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update import logic to dynamically support both new (
llama_index.core.llms) and legacy (llama_index.legacy.llms.custom) versions of thellama_indexpackage. This change ensures compatibility across different versions of the package by using conditional imports and adjustingMODULE_NAMEdynamically based on the available version. This improvement enhances the flexibility and maintainability of the codebase when working with the evolvingllama_indexlibrary.