fix(openai): handle async streaming responses for openai v1 client #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
najork
changed the title
najork
commented
Feb 13, 2024
Comment on lines
+23
to
+39
| @pytest.mark.vcr | ||
| async def test_async_completion(exporter, async_openai_client): | ||
| await async_openai_client.completions.create( | ||
| model="davinci-002", | ||
| prompt="Tell me a joke about opentelemetry", | ||
| ) | ||
|
|
||
| spans = exporter.get_finished_spans() | ||
| assert [span.name for span in spans] == [ | ||
| "openai.completion", | ||
| ] | ||
| open_ai_span = spans[0] | ||
| assert ( | ||
| open_ai_span.attributes["llm.prompts.0.user"] | ||
| == "Tell me a joke about opentelemetry" | ||
| ) | ||
| assert open_ai_span.attributes.get("llm.completions.0.content") |
There was a problem hiding this comment.
I'm happy to split this into its own PR, figured some test coverage for non-streaming async calls would also be beneficial.
|
Thanks @najork! Looks like the tests aren't actually running since we're missing some pytest async plugin (see test run logs).
|
najork
commented
Feb 13, 2024
| @@ -60,22 +60,23 @@ async def acompletion_wrapper(tracer, wrapped, instance, args, kwargs): | |||
| if context_api.get_value(_SUPPRESS_INSTRUMENTATION_KEY): | |||
| return wrapped(*args, **kwargs) | |||
|
|
|||
| async with start_as_current_span_async( | |||
There was a problem hiding this comment.
This was causing span.is_recording() to return false in _abuild_from_streaming_response, in turn causing the response attribute setter to short-circuit, and the test assertion for span content to fail
nirga
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.